feat: add support for data labels in donut charts#9308
Open
djbarnwal wants to merge 3 commits into
Open
Conversation
Contributor
|
cc @Di7design for design review |
Di7design
approved these changes
May 6, 2026
Di7design
left a comment
Di7design
left a comment
There was a problem hiding this comment.
Approved the functionality.
However, we need a better way to improve the label display on small slices, especially for edge cases.
One idea is to hide the label that doesn’t fit in small slices and add a notification below it.
Alternatively, if we need to display all labels for small slices, we could use a line to connect the labels. However, I would recommend displaying 6 labels and then showing “+” followed by “n” more labels.
Please evaluate the efforts for those options and efforts. We can release the feature first, then design and iterate on the follow-up.
Contributor
|
Agreed! I'm okay with either solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to toggle on data labels in pie/donut charts.
Merge this after #9303
https://linear.app/rilldata/issue/APP-818/canvas-pie-chart-unreadable-with-many-slices-add-other-grouping-hover
Checklist: